[
https://issues.apache.org/jira/browse/SUREFIRE-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571029#comment-15571029
]
ASF GitHub Bot commented on SUREFIRE-1293:
------------------------------------------
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/127
> I fixed this issue where I removed [1]
Thank you!
> Because of one method in commons-lang3 we should not pass such a big
library.
ACK
> Instead I created ObjectUtils which has only few method and most of them
is already in Java 7 utility class java.util.Objects. In Surefire on the top of
Java 7 I will delete them and use Java 7 facilities.
Good Idea! Sorry for causing the problems.
> Simplify org.apache.maven.plugin.surefire.report.TestSetRunListener by using
> the null object pattern
> ----------------------------------------------------------------------------------------------------
>
> Key: SUREFIRE-1293
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1293
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Surefire Plugin
> Reporter: Benedikt Ritter
> Assignee: Tibor Digana
> Labels: github
> Fix For: 2.19.2
>
>
> The class org.apache.maven.plugin.surefire.report.TestSetRunListener has a
> lot of checks like this:
> {code:java}
> if( field != null )
> {
> // do something with field
> }
> {code}
> This can be simplified by providing fallback implementations for the fields
> being used by TestSetRunListener.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
