[
https://issues.apache.org/jira/browse/MNG-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986852#comment-15986852
]
ASF GitHub Bot commented on MNG-5899:
-------------------------------------
Github user ifedorenko commented on the issue:
https://github.com/apache/maven/pull/69
I still vote -1 on this change.
While I appreciate "dependency reduced pom" usecase, I'd like the following
two concerns addressed first:
* Mutated pom.xml files must not invalidate original reactor
ProjectDependencyGraph. More specifically, if the original graph allowed
certain build order, the new graph must still allow the same order. In practice
this means the new graph must not have any new dependencies, which is rather
tricky to guarantee when we consider dependency `<excludes>` and dependency
management.
* Implementation must scale well to 5K+ modules and 5K managed external
dependencies. In practice this requires some sort of caching to avoid repeated
reparsing/reinterpollation of reactor pom.xml files.
Additionally, I'd like to understand expected behaviour when projects with
dependency reduced pom files are excluded from the build using `--projects`
command line argument or pom-reducing mojo is not part of selected build phase.
I have not analyzed this in details, but I believe mutable pom.xml files can
lead to odd/unexpected build results that will be difficult to explain and
hence require extra support effort (I happen to help maintain builds for a
reasonably large developer community, so supportability is an important concern
for me).
> Reactor is no longer using the dependency reduced pom created by
> maven-shade-plugin
> -----------------------------------------------------------------------------------
>
> Key: MNG-5899
> URL: https://issues.apache.org/jira/browse/MNG-5899
> Project: Maven
> Issue Type: Bug
> Affects Versions: 3.3.1, 3.3.3
> Reporter: Trask Stalnaker
>
> This works with maven 3.2.5 and prior, but does not work with the latest
> releases (3.3.1 and 3.3.3), or master (tested against 3.3.7-SNAPSHOT).
> I did some bisecting and found the commit that caused the breakage:
> https://github.com/apache/maven/commit/be3fb200326208ca4b8c41ebf16d5ae6b8049792
> In particular, this commit introduced some code to not rebuild the model if
> it was already loaded during reactor resolution.
> This is causing maven not to use the dependency reduced pom created by the
> maven-shade-plugin.
> Removing this code fixes the situation. I'm hoping that code was just
> introduced as a performance optimization, and that I haven't broken anything
> functionally by removing it (the tests still pass at least).
> I will submit a pull request with the change for review.
> Here is the original maven-shade-plugin issue as reported by the Apache Storm
> team: https://issues.apache.org/jira/browse/MSHADE-206
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
