[
https://issues.apache.org/jira/browse/MNG-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987032#comment-15987032
]
ASF GitHub Bot commented on MNG-5899:
-------------------------------------
Github user ifedorenko commented on the issue:
https://github.com/apache/maven/pull/69
I am dead serious. I am not at liberty to disclose exact numbers, but lets
say our main codebase is in the same ballpark if we allow some room for growth.
So 5K modules is not "aspirational pipe dream" kind of goal but very much a
real-life requirement we have. (if you are interested, I can provide some
details about how we use Maven for a project of this size, but maven dev list
is probably a better place to talk about it).
Even in opensource [some
projects](https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668) apparently have
~700 modules.
> Reactor is no longer using the dependency reduced pom created by
> maven-shade-plugin
> -----------------------------------------------------------------------------------
>
> Key: MNG-5899
> URL: https://issues.apache.org/jira/browse/MNG-5899
> Project: Maven
> Issue Type: Bug
> Affects Versions: 3.3.1, 3.3.3
> Reporter: Trask Stalnaker
>
> This works with maven 3.2.5 and prior, but does not work with the latest
> releases (3.3.1 and 3.3.3), or master (tested against 3.3.7-SNAPSHOT).
> I did some bisecting and found the commit that caused the breakage:
> https://github.com/apache/maven/commit/be3fb200326208ca4b8c41ebf16d5ae6b8049792
> In particular, this commit introduced some code to not rebuild the model if
> it was already loaded during reactor resolution.
> This is causing maven not to use the dependency reduced pom created by the
> maven-shade-plugin.
> Removing this code fixes the situation. I'm hoping that code was just
> introduced as a performance optimization, and that I haven't broken anything
> functionally by removing it (the tests still pass at least).
> I will submit a pull request with the change for review.
> Here is the original maven-shade-plugin issue as reported by the Apache Storm
> team: https://issues.apache.org/jira/browse/MSHADE-206
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
