[
https://issues.apache.org/jira/browse/MNG-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018508#comment-16018508
]
ASF GitHub Bot commented on MNG-6207:
-------------------------------------
Github user khmarbaise commented on a diff in the pull request:
https://github.com/apache/maven/pull/119#discussion_r117611940
--- Diff:
maven-model-builder/src/test/java/org/apache/maven/model/validation/DefaultModelValidatorTest.java
---
@@ -604,17 +609,21 @@ public void testBadImportScopeClassifier()
"'dependencyManagement.dependencies.dependency.classifier' for test:a:pom:cls
must be empty" );
}
- public void testSystemPathRefersToProjectBasedir()
+ public void testSystemPathRefersToProjectBasedirAndDeprecatedScope()
--- End diff --
I think it's better having different test cases. Keeping the old test cases
and create new ones for the changed behaviour. That makes it safe not to break
previous behaviour,
> Create WARNINGs in case of using system scope
> ---------------------------------------------
>
> Key: MNG-6207
> URL: https://issues.apache.org/jira/browse/MNG-6207
> Project: Maven
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 3.5.1-candidate, 3.6.0
>
>
> Currently the documentation has already marked the usage of:
> {code:xml}
> <dependency>
> <groupId>javax.sql</groupId>
> <artifactId>jdbc-stdext</artifactId>
> <version>2.0</version>
> <scope>system</scope>
> <systemPath>${java.home}/lib/rt.jar</systemPath>
> </dependency>
> {code}
> as
> [deprecated|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#System_Dependencies].
> So we should start to produce WARNING during a build if someone uses it...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
