[
https://issues.apache.org/jira/browse/MNG-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018958#comment-16018958
]
ASF GitHub Bot commented on MNG-6207:
-------------------------------------
Github user dejan2609 commented on the issue:
https://github.com/apache/maven/pull/119
New changes are pushed via new commit (all commits will be squashed into
one eventually).
Solution is tested across different Maven versions (**3.0.5**, **3.1.1**,
**3.2.5**, **3.3.9** and **3.5.0**).
Test renaming is recalled; however, it seems kind of reasonable (necessary
?) to fine-grain those test cases instead of adding a new one.
**Rationale:** since both existing test cases already consume pom.xml files
with mutually dependent tags:
> \<scope>_**system**_\</scope>
> \<systemPath>_**Some_Path**_\</systemPath>
it seems convenient to carefully reuse those existing test cases, because
both tags end up tested anyway (I reckon that adding a new test case with same
two tags would be redundant).
@khmarbaise: let me know what you think (and please forgive me if my
rationale is not that rational, I'll be ready to dig deeper and accommodate
solution in order to fit standards).
Bonus question (in the unlikely case that I got it all right): does it make
sense to introduce new **ModelBuildingRequest** **_VALIDATION_LEVEL_MAVEN_**
(_**3_5**_ or _**3_6**_) ?
> Create WARNINGs in case of using system scope
> ---------------------------------------------
>
> Key: MNG-6207
> URL: https://issues.apache.org/jira/browse/MNG-6207
> Project: Maven
> Issue Type: Improvement
> Affects Versions: 3.5.0
> Reporter: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 3.5.1-candidate, 3.6.0
>
>
> Currently the documentation has already marked the usage of:
> {code:xml}
> <dependency>
> <groupId>javax.sql</groupId>
> <artifactId>jdbc-stdext</artifactId>
> <version>2.0</version>
> <scope>system</scope>
> <systemPath>${java.home}/lib/rt.jar</systemPath>
> </dependency>
> {code}
> as
> [deprecated|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#System_Dependencies].
> So we should start to produce WARNING during a build if someone uses it...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
