olamy commented on a change in pull request #186: Fixing build on master branch
URL: https://github.com/apache/maven-surefire/pull/186#discussion_r191061703
 
 

 ##########
 File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
 ##########
 @@ -162,7 +162,7 @@
 
         private final Thread inputStreamCloserHook;
 
-        public CloseableCloser( int jvmRun, Closeable... 
testProvidingInputStream )
+        CloseableCloser( int jvmRun, Closeable... testProvidingInputStream )
 
 Review comment:
   why removing public constructor this is not backward compat???? if 
checkstyle complains about this so remove checkstyle usage as it's useless....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to