olamy commented on a change in pull request #186: Fixing build on master branch
URL: https://github.com/apache/maven-surefire/pull/186#discussion_r191088422
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/AbstractClasspathForkConfiguration.java
##########
@@ -37,18 +37,18 @@
{
@SuppressWarnings( "checkstyle:parameternumber" )
- public AbstractClasspathForkConfiguration( @Nonnull Classpath
bootClasspath,
- @Nonnull File tempDirectory,
- @Nullable String debugLine,
- @Nonnull File workingDirectory,
- @Nonnull Properties
modelProperties,
- @Nullable String argLine,
- @Nonnull Map<String, String>
environmentVariables,
- boolean debug,
- int forkCount,
- boolean reuseForks,
- @Nonnull Platform
pluginPlatform,
- @Nonnull ConsoleLogger log )
+ AbstractClasspathForkConfiguration( @Nonnull Classpath bootClasspath,
Review comment:
and what about users/project outside of this project? There are so many
usage of maven by tools (ide etc...) so we have no idea who is using those
classes. They are public so keep them public as we don't know... Backward
compatibility for opensource library/project with large audience is a pain but
we must maintain it... and it's more important than a checkstyle failure.....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
