cardil commented on a change in pull request #186: Fixing build on master branch
URL: https://github.com/apache/maven-surefire/pull/186#discussion_r191078959
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/AbstractClasspathForkConfiguration.java
##########
@@ -37,18 +37,18 @@
{
@SuppressWarnings( "checkstyle:parameternumber" )
- public AbstractClasspathForkConfiguration( @Nonnull Classpath
bootClasspath,
- @Nonnull File tempDirectory,
- @Nullable String debugLine,
- @Nonnull File workingDirectory,
- @Nonnull Properties
modelProperties,
- @Nullable String argLine,
- @Nonnull Map<String, String>
environmentVariables,
- boolean debug,
- int forkCount,
- boolean reuseForks,
- @Nonnull Platform
pluginPlatform,
- @Nonnull ConsoleLogger log )
+ AbstractClasspathForkConfiguration( @Nonnull Classpath bootClasspath,
Review comment:
This constructor wasn't used outside the package. Intellij also confirms it,
so checkstyle reports it properly. Also keep in mind that tests passes. If it
not being used, access can be safly lowered to package level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
