cardil commented on a change in pull request #186: Fixing build on master branch
URL: https://github.com/apache/maven-surefire/pull/186#discussion_r191089834
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/AbstractClasspathForkConfiguration.java
##########
@@ -37,18 +37,18 @@
{
@SuppressWarnings( "checkstyle:parameternumber" )
- public AbstractClasspathForkConfiguration( @Nonnull Classpath
bootClasspath,
- @Nonnull File tempDirectory,
- @Nullable String debugLine,
- @Nonnull File workingDirectory,
- @Nonnull Properties
modelProperties,
- @Nullable String argLine,
- @Nonnull Map<String, String>
environmentVariables,
- boolean debug,
- int forkCount,
- boolean reuseForks,
- @Nonnull Platform
pluginPlatform,
- @Nonnull ConsoleLogger log )
+ AbstractClasspathForkConfiguration( @Nonnull Classpath bootClasspath,
Review comment:
I don't buy that. Those are some internal classes, not a part of any API. I
fact I don't think that any part of surefire-plugin is a API. Is there any real
projects, that rely on surefire internal classes?
I think that eventual API classes and interfaces should be marked strictly
as API and kept backward compatible. But not internal classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
