[
https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689749#comment-16689749
]
ASF GitHub Bot commented on MJAR-260:
-------------------------------------
sormuras commented on issue #3: [MJAR-260] Fail on invalid automatic module name
URL: https://github.com/apache/maven-jar-plugin/pull/3#issuecomment-439471640
> > Seems there is a failure
https://builds.apache.org/job/maven-box/job/maven-jar-plugin/job/MJAR-260-Automatic-Module-Name/2/
>
> Wrong source file encoding used for javac? Locally, all tests and ITs are
green.
No, the real reason was the `_` (underscore) which is not invalid on Java 7.
Removed the check as it is not relevant in this context. Force-pushed changes
to this branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Warn about invalid 'Automatic-Module-Name' in MANIFEST
> ------------------------------------------------------
>
> Key: MJAR-260
> URL: https://issues.apache.org/jira/browse/MJAR-260
> Project: Maven JAR Plugin
> Issue Type: Improvement
> Reporter: Christian Stein
> Assignee: Christian Stein
> Priority: Minor
>
> The Maven JAR Plugin should warn or even fail when an invalid name is
> detected within the `META-INF/MANIFEST.MF` file.
> For details see
> https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
