[
https://issues.apache.org/jira/browse/MJAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689877#comment-16689877
]
ASF GitHub Bot commented on MJAR-260:
-------------------------------------
sormuras commented on a change in pull request #3: [MJAR-260] Fail on invalid
automatic module name
URL: https://github.com/apache/maven-jar-plugin/pull/3#discussion_r234313690
##########
File path: src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
##########
@@ -223,6 +226,18 @@ public File createArchive()
archiver.createArchive( session, project, archive );
+ JarFile javaUtilJarFile = new JarFile( jarFile );
Review comment:
Yes to both of your suggestions.
- Will re-use the archive configuration (preventing the resource leak)
- Will "move" the PR to https://github.com/apache/maven-archiver
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Warn about invalid 'Automatic-Module-Name' in MANIFEST
> ------------------------------------------------------
>
> Key: MJAR-260
> URL: https://issues.apache.org/jira/browse/MJAR-260
> Project: Maven JAR Plugin
> Issue Type: Improvement
> Reporter: Christian Stein
> Assignee: Christian Stein
> Priority: Minor
>
> The Maven JAR Plugin should warn or even fail when an invalid name is
> detected within the `META-INF/MANIFEST.MF` file.
> For details see
> https://sormuras.github.io/blog/2018-11-16-invalid-automatic-module-names
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
