rmannibucau commented on a change in pull request #11: [MSHADE-307] adding 
useDefaultConfiguration flag in ShadeMojo
URL: https://github.com/apache/maven-shade-plugin/pull/11#discussion_r241987072
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
 ##########
 @@ -762,55 +766,72 @@ private File resolveArtifactSources( Artifact artifact )
 
     private List<ResourceTransformer> getResourceTransformers()
     {
+        final List<ResourceTransformer> resourceTransformers = new 
LinkedList<>( getDefaultResourceTransformers() );
         if ( transformers == null )
         {
-            return Collections.emptyList();
+            return resourceTransformers;
 
 Review comment:
   I'm fine to disagree but I'd like to solve the issue which aims to reduce 
the entry cost of the plugin and save hours of debug time due to a bad 
packaging which is hard to identify - and even more with jpms since 
module-info.java drops SPI registration :s.
   
   any alternative proposal to have a trivial to enable good auto configuration 
compatible with user customizations?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to