rmannibucau commented on a change in pull request #11: [MSHADE-307] adding
useDefaultConfiguration flag in ShadeMojo
URL: https://github.com/apache/maven-shade-plugin/pull/11#discussion_r241987775
##########
File path: src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
##########
@@ -762,55 +766,72 @@ private File resolveArtifactSources( Artifact artifact )
private List<ResourceTransformer> getResourceTransformers()
{
+ final List<ResourceTransformer> resourceTransformers = new
LinkedList<>( getDefaultResourceTransformers() );
if ( transformers == null )
{
- return Collections.emptyList();
+ return resourceTransformers;
Review comment:
Ok, let's split. Just to ensure I get it and not do work for nothing, it
means 3 PR - no order:
1. defaults (transformers and filters)
2. SPI
3. combine
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services