eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-459143477 See my previous comments above. This change will break other implementations not covered by testcases. IMO we should add test cases to demonstrate that we are not breaking such case (you can file separate PRs for each new integration test) Once we have such tests you will be able to eventually tune your patch in order not to break the issues spotted above
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
