eolivelli commented on issue #5: [MCHECKSTYLE-353] - Don't resolve any 
dependencies
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/5#issuecomment-460376346
 
 
   @zregvart  than you so much for you work
   
   seems that this patch is against another issue:
   https://issues.apache.org/jira/browse/MCHECKSTYLE-166
   
   For sure we are missing important integration tests around core checkstyle 
features.
   We have to add tests to prove MCHECKSTYLE-166 I guess this patch will break 
that behaviour.
   
   I guess the safest way would be to add a new mojo.
   
   Otherwise we should introduce some more complex implementation which allows 
to not download/resolve dependencies.
   
   cc @rfscholte 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to