Tibor17 commented on a change in pull request #226: Extended SimpleReportEntry
with sourceText and nameText
URL: https://github.com/apache/maven-surefire/pull/226#discussion_r272800009
##########
File path:
surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformIT.java
##########
@@ -40,27 +41,24 @@ public void setUp()
public void testJupiterEngine()
{
unpack( "/junit-platform-engine-jupiter" )
+ .setTestToRun( "Basic*Test" )
.executeTest()
.verifyErrorFree( 5 );
}
@Test
- @Ignore( "Uncomment while developing SUREFIRE-1222. Rename 'javax'
extension of DisplayNameTest.javax." )
Review comment:
This was the main test for this change.
The DisplayName is permanently enabled in this commit which is still not
good because the user should switch it on/off in the configuration. So
therefore we are waiting for the extensions and config changes. Basically this
test tells us that the strings with display name and good encoding is in TXT
and XML reports however still permanently enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
