[
https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817267#comment-16817267
]
Tibor Digana edited comment on SUREFIRE-1546 at 4/14/19 10:54 AM:
------------------------------------------------------------------
[~Srdo]
[~marcphilipp]
It's clear what I said. You had a problem and I showed you my opinion with
another annotations which make sense to me.
In my opinion users want to see test methods and classes in HTML, so why we are
talking about container and its display name.
It is better to list all attributes which want to be shown on HTML and then we
will see if JUnit5 can currently cover those, and not to talk about "how to do
this and that technically" instead of writing a manifesto with this list of
attributes.
IMHO what you guys have showed me is a technical problem in JUnit where the
annotation {{DisplayName}} does not show {{x = bar(15)}} and {{x = bar(54)}}
which I would expect (according the experiences with JUnit4) as a user. The
next problem is that DisplayName talks about string constant, but JUnit5 adds
something to the end: {{(bar(int))}} which I as user would not like to see
because the framework is adding it unexpectedly and I do not have the string
under control => therefore my sample code. Are we talking about bug in JUnit5
or HTML report?
was (Author: tibor17):
[~Srdo]
[~marcphilipp]
It's clear what I said. You had a problem and I showed you my opinion with
another annotations which make sense to me.
In my opinion users want to see test methods and classes in HTML, so why we are
talking about container and its display name.
It is better to list all attributes which want to be shown on HTML and then we
will see if JUnit5 can currently cover those, and not to talk about "how to do
this and that technically" instead of writing a manifesto with this list of
attributes.
IMHO what you guys have showed me is a technical problem in JUnit where the
annotation {{DisplayName}} does not show {{x = bar(15)}} and {{x = bar(54)}}
which I would expect (according the experiences with JUnit4) as a user. The
next problem is that DisplayName talks about string constant, but JUnit5 adds
something to the end: {{(bar(int))}} which I as user would not like to see
because the framework is adding it unexpectedly and I do not have the string
under control => therefore my sample code. Are we about a bug in JUnit5 or HTML
report?
> JUnit 5 runner does not honor JUnit 5 display names
> ---------------------------------------------------
>
> Key: SUREFIRE-1546
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1546
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
> Affects Versions: 2.22.0
> Reporter: Romain Manni-Bucau
> Assignee: Tibor Digana
> Priority: Major
> Labels: junit5
> Fix For: 3.0.0-M4
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> JUnit 5 runner should respect the test @DisplayName instead of displaying the
> classname if any is defined. Seems last release doesn't support that feature
> of JUnit 5 making the console output and reports not the expected ones.
>
> Origin: https://github.com/junit-team/junit5/issues/990
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
