cardil commented on issue #112: Adding support for externally passed random 
seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-497644398
 
 
   > The confusing thing is that if I pass `random:1` it becomes `random:100001`
   > Using value `random:1` was my first intuitive experiment and initially I 
thought that my argument was just ignored.
   > I see that there is a constant `Randomizer.LOWER_BOUND = 100000` limiting 
it. I do not see reasons not to have value `1` (or even `0`). I changed it and 
ran tests with seed 1 and 2 and I see that tests are shuffled very well.
   
   My intention on `LOWER_BOUND` was that to ensure that generated seed be 
always the same length in chars. I think that I will change it to not force 
values to be changed, so if user gives `random:1` effective seed will be `1`. 
But if user do not pass a seed, like `random`, then `LOWER_BOUND` will be used 
to generate new value.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to