cardil commented on issue #112: Adding support for externally passed random 
seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498614725
 
 
   @Tibor17 I agree that will significantly simplify the code. But, I'm 
wondering is there a reason someone addred `RunOrder[]`. Maybe the is some 
fringe use case for that.
   
   EDIT: I was looking at repo. `RunOrder[]` was introduced here: 
https://github.com/apache/maven-surefire/commit/13e6736b8cabc04be9b98c71a2a9695391d1f1a1
 There is a unit test here: 
https://github.com/apache/maven-surefire/commit/13e6736b8cabc04be9b98c71a2a9695391d1f1a1#diff-5be1142c69251dcc5baa91176c27d284R42
 that showcases the use case for multiple run orders. It's 
`"failedfirst,alphabetical"`. I think that intention was to order failed first 
and then alphabetical. It looks a bit like a quick hack to me. In the current 
code those tests are no more. I wasn't looking at a reason for multiple 
`RunOrder[]`, before. Maybe failedfirst is now handled in other way?!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to