joakime commented on a change in pull request #46: [MNG-6731] Jetty getLocalPort() returns -1 resulting in build failures URL: https://github.com/apache/maven-integration-testing/pull/46#discussion_r314287943
########## File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0768OfflineModeTest.java ########## @@ -103,17 +103,12 @@ else if ( request.getRequestURI().endsWith( ".md5" ) || request.getRequestURI(). try { server.start(); - while ( !server.isRunning() || !server.isStarted() ) + if ( server.isFailed() ) Review comment: This state is not possible to reach immediately after `server.start()` in a Bind failure scenario. The ServerConnector's doStart will attempt to bind The BindException gets thrown for failure to bind A IOException wraps failure to bind during ServerConnector doStart The Server doStart captures the IOException and adds it to the MultiException its tracking At the end of Server doStart the MultiException throws if it has any exceptions its tracking. This scenario should result in a IOException or MultiException from server.start() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services