joakime commented on a change in pull request #46: [MNG-6731] Jetty 
getLocalPort() returns -1 resulting in build failures
URL: 
https://github.com/apache/maven-integration-testing/pull/46#discussion_r314347605
 
 

 ##########
 File path: 
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0553SettingsAuthzEncryptionTest.java
 ##########
 @@ -86,18 +93,13 @@ protected void setUp()
         handlerList.addHandler( repoHandler );
         handlerList.addHandler( new DefaultHandler() );
 
-        server = new Server( 0 );
         server.setHandler( handlerList );
         server.start();
-        while ( !server.isRunning() || !server.isStarted() )
+        if ( server.isFailed() )
 
 Review comment:
   If you have parallel processes sure.
   But your usages are sequential.
   If you decided to use something like DeploymentManager to scan for webapps 
and deploy them, then you would be interested in ThrowUnavailableOnStartup, 
which waits for initial deployment to report failures to Server.start

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to