Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r347678843
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -3370,16 +3362,15 @@ public void setSystemPropertyVariables( Map<String,
String> systemPropertyVariab
this.systemPropertyVariables = systemPropertyVariables;
}
- public File getSystemPropertiesFile()
- {
- return systemPropertiesFile;
- }
+ /**
+ * List of System properties, loaded from a file, to pass to the JUnit
tests.
+ *
+ * @since 2.8.2
+ */
+ public abstract File getSystemPropertiesFile();
@SuppressWarnings( "UnusedDeclaration" )
- public void setSystemPropertiesFile( File systemPropertiesFile )
- {
- this.systemPropertiesFile = systemPropertiesFile;
- }
+ public abstract void setSystemPropertiesFile( File systemPropertiesFile );
Review comment:
Several days ago I committed a unit test whih simply fetched the value to
this field using the PowerMock.
Pls utilize the same idea and try to cover the tests on the getters and
setters you added. Pls try to cover the `catch` block with the exception.
Now the coverage slowly grows and it goes with all the effort but it is
positive thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
