Tibor17 commented on a change in pull request #152: [SUREFIRE-1378] Nice to
have systemPropertiesFile configurable by user property
URL: https://github.com/apache/maven-surefire/pull/152#discussion_r348176744
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
##########
@@ -3370,16 +3362,15 @@ public void setSystemPropertyVariables( Map<String,
String> systemPropertyVariab
this.systemPropertyVariables = systemPropertyVariables;
}
- public File getSystemPropertiesFile()
- {
- return systemPropertiesFile;
- }
+ /**
+ * List of System properties, loaded from a file, to pass to the JUnit
tests.
+ *
+ * @since 2.8.2
+ */
+ public abstract File getSystemPropertiesFile();
@SuppressWarnings( "UnusedDeclaration" )
- public void setSystemPropertiesFile( File systemPropertiesFile )
- {
- this.systemPropertiesFile = systemPropertiesFile;
- }
+ public abstract void setSystemPropertiesFile( File systemPropertiesFile );
Review comment:
Not to repeat.
Only my hint to make your life easier :-)
Example in the commit `80659dc4`:
```
public void testShouldGetEnv()
{
SurefirePlugin plugin = new SurefirePlugin();
plugin.setExcludedEnvironmentVariables( new String[] { "ABC", "KLM"
} );
assertThat( plugin.getExcludedEnvironmentVariables() )
.hasSize( 2 )
.contains( "ABC", "KLM" );
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
