[
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004732#comment-17004732
]
Herve Boutemy commented on MSHADE-339:
--------------------------------------
thanks [~peterdm]
I had a look at Artifact interface
https://maven.apache.org/ref/3.6.3/maven-artifact/apidocs/org/apache/maven/artifact/Artifact.html
and its default implementation
the root issue is in this interface, which mixes artifact features with
dependency features, then it's hard to really use only one aspect...
IMHO if we consider that the MavenProjectHelper parameter is a type (which it
actually is given the implementation), we should attach with "test-jar" type
and no classifier, since the implementation will fill with the default
classifier https://maven.apache.org/ref/3.6.3/maven-core/artifact-handlers.html
if we consider we want to use it more as an extension (which is IMHO more
logical given
https://maven.apache.org/shared/maven-artifact-transfer/comparison.html), we
should use "jar" extension and "tests" classifier
of course, if your IT can prove one provides different result than the other
(which is not obvious to me), this will give us a preference for one
implementation over the other...
> Shaded test jar has wrong type "jar"
> ------------------------------------
>
> Key: MSHADE-339
> URL: https://issues.apache.org/jira/browse/MSHADE-339
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 2.2, 3.2.2
> Reporter: Peter De Maeyer
> Priority: Minor
> Fix For: 3.2.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
