[ 
https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013572#comment-17013572
 ] 

Peter De Maeyer commented on MSHADE-339:
----------------------------------------

I updated the pull request with the "attach( "test-jar" )" solution, since we 
all agree on that.

Note that it's now a bit inconsistent with "attach( "java-source", "sources" )" 
a couple of lines above, which could ultimately become "attach( "java-sources" 
)" as well following the same rationale. My fingers were itching to bring that 
in line too, but I didn't want to stir up the debate again, so I left it alone.

> Shaded test jar has wrong type "jar"
> ------------------------------------
>
>                 Key: MSHADE-339
>                 URL: https://issues.apache.org/jira/browse/MSHADE-339
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2, 3.2.2
>            Reporter: Peter De Maeyer
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: 3.2.2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to