rosti-il commented on issue #307: Simplify detection of the MAVEN_HOME and make it fully qualified URL: https://github.com/apache/maven/pull/307#issuecomment-570222347 I want to change this line in my commit: `set "MAVEN_HOME=%MAVEN_HOME:\bin\=%"` into this one: `set "MAVEN_HOME=%MAVEN_HOME:~0,-5%"` The reason: it's safer because theoretically the "/bin/" substring could appear more than once but we need to remove only the last one. I will amend my commit and push force it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
