michael-o commented on a change in pull request #307: Simplify detection of the MAVEN_HOME and make it fully qualified URL: https://github.com/apache/maven/pull/307#discussion_r364982393
########## File path: apache-maven/src/bin/mvn.cmd ########## @@ -60,15 +60,11 @@ echo NB: JAVA_HOME should point to a JDK not a JRE >&2 goto error :chkMHome -set "MAVEN_HOME=%~dp0.." -if not "%MAVEN_HOME%"=="" goto stripMHome +set "MAVEN_HOME=%~dp0" +set "MAVEN_HOME=%MAVEN_HOME:~0,-5%" Review comment: This cannot be combined into one `set`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
