elharo commented on a change in pull request #27: MJAVADOC-617 Normalize module
path so that '..' in the path are resolved
URL:
https://github.com/apache/maven-javadoc-plugin/pull/27#discussion_r389616079
##########
File path:
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
##########
@@ -2393,7 +2393,7 @@ protected void executeReport( Locale unusedLocale )
List<Path> modulePaths = new LinkedList<>();
for ( String module : aggregatedProject.getModules() )
{
- modulePaths.add( new File( aggregatedProject.getBasedir(), module
).toPath() );
+ modulePaths.add( new File( aggregatedProject.getBasedir(), module
).toPath().normalize() );
Review comment:
You can probably use Paths.get here and avoid the File class completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services