elharo commented on a change in pull request #27: MJAVADOC-617 Normalize module 
path so that '..' in the path are resolved
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/27#discussion_r400287916
 
 

 ##########
 File path: 
src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java
 ##########
 @@ -232,15 +232,7 @@ public void testAggregateJavadocResources()
         File apidocs = new File( getBasedir(), 
"target/test/unit/aggregate-resources-test/target/site/apidocs" );
 
         // Test overview
-        File overviewSummary;
-        if ( JavaVersion.JAVA_SPECIFICATION_VERSION.isBefore( "11" ) )
-        {
-            overviewSummary = new File( apidocs, "overview-summary.html" );
-        }
-        else
-        {
-            overviewSummary = new File( apidocs, "index.html" );
-        }
+        File overviewSummary = getOverviewSummary(apidocs);
         
         assertTrue( overviewSummary.exists() );
         String overview = readFile( overviewSummary ).toLowerCase();
 
 Review comment:
   toLowerCase needs a locale

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to