[ 
https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064302#comment-17064302
 ] 

Slawomir Jaranowski commented on MSKINS-161:
--------------------------------------------

I see some more work connected with usually project maintenance, so:
- update parent pom 30 -> 34
- update plugins:
{code}
[INFO] com.samaxes.maven:maven-minify-plugin ............ 1.3.5 -> 1.3.5.1
[INFO] maven-invoker-plugin ................................ 1.10 -> 3.1.0
[INFO] maven-resources-plugin ............................... 2.7 -> 3.1.0
{code}

Do I should create separate task for each of those task ... or can I prepare 
many PR connected with this issue? 

> Upgrade Facebook like button integration
> ----------------------------------------
>
>                 Key: MSKINS-161
>                 URL: https://issues.apache.org/jira/browse/MSKINS-161
>             Project: Maven Skins
>          Issue Type: Improvement
>          Components: Fluido Skin
>    Affects Versions: fluido-1.8
>            Reporter: Slawomir Jaranowski
>            Priority: Major
>         Attachments: Screenshot 2020-03-22 at 10.31.29.png
>
>
> Current Facebook integration use iframe and "Like button" is cropped.
> Upgrading to newer facebook sdk can help in cropping "like button".
>  
> We also have some configurations for "like button"
> - action type like or recommend
> - share button visibility
> - layout
> - button size
> - ...
> some of those should have possibility to configured by site.xml
> [https://developers.facebook.com/docs/plugins/like-button/]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to