[
https://issues.apache.org/jira/browse/MSKINS-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065958#comment-17065958
]
Slawomir Jaranowski commented on MSKINS-161:
--------------------------------------------
What do you think about replace maven-resources-plugin by maven-assembly-plugin
for copying it tests results to site.
Instead of:
{code}
<executions>
<execution>
<id>copy-sidebar</id>
<phase>site</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<resources>
<resource>
<directory>${project.build.directory}/it/sidebar/target/site/</directory>
</resource>
</resources>
<outputDirectory>${project.build.directory}/site/sidebar/</outputDirectory>
</configuration>
</execution>
{code}
in pom.xml we can have (something like) in assembly.xml:
{code}
<fileSets>
<fileSet>
<directory>${project.build.directory}/it/sidebar/target/site/</directory>
<outputDirectory>${project.build.directory}/site/sidebar/</outputDirectory>
</fileSet>
</fileSets>
{code}
It will be more readable and easier to maintenance.
> Upgrade Facebook like button integration
> ----------------------------------------
>
> Key: MSKINS-161
> URL: https://issues.apache.org/jira/browse/MSKINS-161
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.8
> Reporter: Slawomir Jaranowski
> Priority: Major
> Attachments: Screenshot 2020-03-22 at 10.31.29.png
>
>
> Current Facebook integration use iframe and "Like button" is cropped.
> Upgrading to newer facebook sdk can help in cropping "like button".
>
> We also have some configurations for "like button"
> - action type like or recommend
> - share button visibility
> - layout
> - button size
> - ...
> some of those should have possibility to configured by site.xml
> [https://developers.facebook.com/docs/plugins/like-button/]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
