elharo commented on a change in pull request #27: [MJAVADOC-617] Normalize module path so that '..' in the path are resolved URL: https://github.com/apache/maven-javadoc-plugin/pull/27#discussion_r401505221
########## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ########## @@ -1,5 +1,43 @@ package org.apache.maven.plugins.javadoc; +import static org.apache.maven.plugins.javadoc.JavadocUtil.isEmpty; Review comment: I missed that the imports were reorganized. If this is existing code, no need to fix it here. I don't know if maven follows any conventions for import ordering, but absent that it's best not to reorder imports to avoid churn. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
