elharo commented on a change in pull request #27: [MJAVADOC-617] Normalize
module path so that '..' in the path are resolved
URL:
https://github.com/apache/maven-javadoc-plugin/pull/27#discussion_r401505922
##########
File path:
src/test/java/org/apache/maven/plugins/javadoc/AggregatorJavadocReportTest.java
##########
@@ -257,4 +250,25 @@ public void testAggregateJavadocResources()
assertTrue( overview.contains( "<img
src=\"doc-files/maven-feather.png\" alt=\"Maven\">" ) );
assertTrue( new File( apidocs,
"resources/test/doc-files/maven-feather.png" ).exists() );
}
+
+ public void testAggregateWithModulsNotInSubFolders() throws Exception
+ {
+ File testPom = new File( unit,
"aggregate-modules-not-in-subfolders-test/all/pom.xml");
+ JavadocReport mojo = lookupMojo( testPom );
+ mojo.execute();
+
+ File apidocs = new File( getBasedir(),
"target/test/unit/aggregate-modules-not-in-subfolders-test/target/site/apidocs"
);
+ assertTrue( apidocs.exists() );
Review comment:
apidocs.isDirectory() would be slightly stronger test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
