nfalco79 commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r428507839



##########
File path: 
maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java
##########
@@ -58,7 +59,9 @@ public ReleaseDescriptorBuilder addCheckModificationExclude( 
String string )
 
     public ReleaseDescriptorBuilder setActivateProfiles( List<String> profiles 
)
     {
-        releaseDescriptor.setActivateProfiles( profiles );
+        List<String> copy = new ArrayList<>();
+        copy.addAll( profiles );

Review comment:
       If I understand right here you would to instantiate a new 
ReleaseDescriptorBuilder with the sum of active profiles something like:
   ```
   Properties props = new Properties();
   props.put("exec.activateProfiles", profiles);
   ReleaseUtil.copyPropertiesToReleaseDescriptor(props , releaseDescriptor)
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to