rfscholte commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r428602013
##########
File path:
maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java
##########
@@ -58,7 +59,9 @@ public ReleaseDescriptorBuilder addCheckModificationExclude(
String string )
public ReleaseDescriptorBuilder setActivateProfiles( List<String> profiles
)
{
- releaseDescriptor.setActivateProfiles( profiles );
+ List<String> copy = new ArrayList<>();
+ copy.addAll( profiles );
Review comment:
Looks a bit weird, right? I can imagine there should be an extra method
or class.
Based on this I discovered that ReleaseUtils should be adjusted a bit:
```
public static ReleaseDescriptor buildReleaseDescriptor(
ReleaseDescriptorBuilder builder )
{
return builder.build();
}
```
It exposes another hack: `config.setCompletedPhase( name );`, but this one
is easy to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
