mthmulders commented on a change in pull request #286:
URL: https://github.com/apache/maven/pull/286#discussion_r439851642



##########
File path: 
maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
##########
@@ -269,7 +273,7 @@ private DependencyResolutionResult resolveDependencies( 
MavenProject project, Re
         return ids;
     }
 
-    private ModelBuildingRequest getModelBuildingRequest( InternalConfig 
config )
+    private ModelBuildingRequest getModelBuildingRequest( InternalConfig 
config, File pomFile )

Review comment:
       Why is the second argument added? I can't see it being used in the 
`getModelBuildingRequest` method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to