mthmulders commented on a change in pull request #286:
URL: https://github.com/apache/maven/pull/286#discussion_r439853137
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -646,8 +657,33 @@ else if ( modelSource instanceof FileModelSource )
{
model.setPomFile( ( (FileModelSource) modelSource ).getFile() );
}
-
problems.setSource( model );
+
+ modelValidator.validateFileModel( model, request, problems );
+ request.setFileModel( model );
+
+ if ( Features.buildConsumer().isActive() && pomFile != null )
+ {
+ try
Review comment:
Would it be possible to refactor this addition (and others) to the
`readModel` method into separate methods? The fact that we now need to
`@SuppressWarnings` about method length is a sign that the method is, well,
lengthy ;-).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
