Tibor17 commented on a change in pull request #309:
URL: https://github.com/apache/maven-surefire/pull/309#discussion_r464949748



##########
File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
##########
@@ -310,6 +310,22 @@
     @Parameter( property = "failsafe.runOrder", defaultValue = "filesystem" )
     private String runOrder;
 
+    /**
+     * Sets the random seed that will be used to order the tests if {@code 
failsafe.runOrder} is set to {@code random}.
+     * <br>
+     * <br>
+     * If no seeds are set and {@code failsafe.runOrder} is set to {@code 
random}, then the seed used will be
+     * outputted (search for "To reproduce ordering use flag -Dfailsafe.seed").
+     * <br>
+     * <br>
+     * To deterministically reproduce any random test order that was run 
before, simply set the seed to 
+     * be the same value.
+     *
+     * @since 3.0.0-M6
+     */
+    @Parameter( property = "failsafe.seed" )
+    private Long randomSeed;

Review comment:
       @rmannibucau This way we would have too many config params. Having it in 
one means that it is about the same business. Here you are setting only run 
order and so that you say "random" is the same business value with the "seed".
   Alternatively it can be done another way with the extensions where this 
parameter may become an interface. It means that the parameter "runOrder" would 
become an element what is called complexType in the XML and it may have 
specific nested elements for the concrete implementation of the interface, and 
the "seed" would be only for the "random".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to