rmannibucau commented on a change in pull request #309:
URL: https://github.com/apache/maven-surefire/pull/309#discussion_r464988133



##########
File path: 
maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/IntegrationTestMojo.java
##########
@@ -310,6 +310,22 @@
     @Parameter( property = "failsafe.runOrder", defaultValue = "filesystem" )
     private String runOrder;
 
+    /**
+     * Sets the random seed that will be used to order the tests if {@code 
failsafe.runOrder} is set to {@code random}.
+     * <br>
+     * <br>
+     * If no seeds are set and {@code failsafe.runOrder} is set to {@code 
random}, then the seed used will be
+     * outputted (search for "To reproduce ordering use flag -Dfailsafe.seed").
+     * <br>
+     * <br>
+     * To deterministically reproduce any random test order that was run 
before, simply set the seed to 
+     * be the same value.
+     *
+     * @since 3.0.0-M6
+     */
+    @Parameter( property = "failsafe.seed" )
+    private Long randomSeed;

Review comment:
       @Tibor17 fact it creates less parameters is irrelevant - in particular 
today we have a tons of parameters. Fact it makes it harder to use, integrate 
and is more error prone for end users is what counts at the end and here having 
a dedicated variable for the replay is highly relevant IMHO. Also note that 
having the seed is not always enough to replay a test suite (in particular in 
random mode) so you can just need to capture the test order and replay it 
explicitly (a runOrder=fromFile and runOrderFile=/path would be more relevant 
there).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to