[ 
https://issues.apache.org/jira/browse/MSHADE-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231336#comment-17231336
 ] 

Delany commented on MSHADE-251:
-------------------------------

[~rfscholte] again you raise the issue of code smells, but this is a usability 
issue. I want to add the plugin, get it into source and test it out, and when 
its ready I'll flip the switch. The real code smell is that Maven doesn't 
provide a skip config for all plugins by default

> Add skip parameter to shade goal
> --------------------------------
>
>                 Key: MSHADE-251
>                 URL: https://issues.apache.org/jira/browse/MSHADE-251
>             Project: Maven Shade Plugin
>          Issue Type: New Feature
>            Reporter: Jonathan Haber
>            Priority: Minor
>
> Most Maven plugins have a skip parameter but not the shade plugin. Our 
> use-case is that we have multiple ways of packaging apps for deployment 
> (using the shade plugin is one such way). We have these packaging plugins 
> defined in our shared parent POM and projects can use Maven properties to 
> control which ones to skip and which to execute.
> We've added this feature on our fork (which you can view 
> [here|https://github.com/HubSpot/maven-plugins/compare/3fb23118d33d842e56a05cc94388d0b40f1bd7e3...811af68429b3728eaef1f8fc42a32bdb2571a8b1]).
>  It's not much code and having a skip parameter can be a lifesaver when you 
> need it, so I was hoping this feature could get added. Let me know what you 
> think.
> Thanks,
>  Jonathan



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to