[
https://issues.apache.org/jira/browse/MSHADE-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231384#comment-17231384
]
Robert Scholte commented on MSHADE-251:
---------------------------------------
Any parameter that can be set from commandline AND effects the result of the
artifact should be banned. Otherwise we'll get the other discussions: why
doesn't my project compile( or even worse .. run) anymore? Oh, because
somebody added -Dshade.skip and now the classes aren't relocated.
As one of the plugin maintainer I'm not giong to take responsibility for that
at a plugin level. You are allowed to do it on a project level by adding
profiles to the pom. Having reliable builds is much more important compared to
flexibility with skip parameters.
Regarding inheritence (specify the plugin in a parent pom, and only let a
subset use it) is already possible when pluginManagement, but it could be
improved.
> Add skip parameter to shade goal
> --------------------------------
>
> Key: MSHADE-251
> URL: https://issues.apache.org/jira/browse/MSHADE-251
> Project: Maven Shade Plugin
> Issue Type: New Feature
> Reporter: Jonathan Haber
> Priority: Minor
>
> Most Maven plugins have a skip parameter but not the shade plugin. Our
> use-case is that we have multiple ways of packaging apps for deployment
> (using the shade plugin is one such way). We have these packaging plugins
> defined in our shared parent POM and projects can use Maven properties to
> control which ones to skip and which to execute.
> We've added this feature on our fork (which you can view
> [here|https://github.com/HubSpot/maven-plugins/compare/3fb23118d33d842e56a05cc94388d0b40f1bd7e3...811af68429b3728eaef1f8fc42a32bdb2571a8b1]).
> It's not much code and having a skip parameter can be a lifesaver when you
> need it, so I was hoping this feature could get added. Let me know what you
> think.
> Thanks,
> Jonathan
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
