rfscholte commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549108105
##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
</properties>
</profile>
-->
+ <profile>
+ <activation>
Review comment:
To me the `settings.xml` is a Maven specific file (unlike the
`pom.xml`). I see this as an opportunity to improve the `settings.xml` right
now. I don't like the idea of a temporary solution now of which we know it'll
be changed. Those temporary hybrid style settings will be there forever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
