michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549108923



##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
       </properties>
     </profile>
     -->
+    <profile>
+      <activation>

Review comment:
       So you want to bump settings model to 2.0.0 and introduce repos there? 
What will happen when pre-4.0.0 will try to read this settings file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to