[ 
https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291617#comment-17291617
 ] 

Maarten Mulders commented on MNG-7051:
--------------------------------------

{quote}I have a question on this feature: in the case of a multi-module build, 
is the check done on each module, or on the global multi-module build?{quote}

* Specifying {{-P whatever}}, if a profile only exists in at least one of many 
submodules, will not break or log a warning.
* Specifying {{-P whatever}}, if there is no submodule in the whole tree with 
that profile defined, will break.
* Specifying {{-P "?whatever"}}, if the profile is nowhere defined, will log a 
warning about non-existing profile twice (that was already introduced before 
this change).
* Specifying {{-P "?whatever"}}, if a profile exists in at least one of many 
submodules, will not log the warning.

I plan to look at your proposed changes for MNG-7107 later today. If I 
understand correctly, those changes make MNG-7052 superfluous, is that correct?

> Optionally skip non-existing profiles
> -------------------------------------
>
>                 Key: MNG-7051
>                 URL: https://issues.apache.org/jira/browse/MNG-7051
>             Project: Maven
>          Issue Type: Sub-task
>          Components: Profiles
>            Reporter: Maarten Mulders
>            Assignee: Martin Kanters
>            Priority: Major
>             Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> For Maven 4, the behaviour of the {{-P}} command line option will change:
>  * {{-P apache-release}} will activate the *apache-release* profile. If such 
> a profile cannot be found, the build will break.
>  * {{-P ?apache-release}} will activate the *apache-release* profile. If such 
> a profile cannot be found, the build will continue but log a warning.
> {color:#ff0000}
> Note that this breaks the current behaviour of Maven 3 in two ways:
> {color}
> # {{-P apache-release}} will currently log a warning and not break the build. 
> That behaviour can be restored by adding the {{?}}.
> # A profile that has an identifier that not valid (i.e., contains anything 
> else than {{a}} - {{z}}, {{A}} to {{Z}}, {{0}} - {{9}}, {{-}}, {{_}} or 
> {{.}}) will break the build.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to