[
https://issues.apache.org/jira/browse/MNG-7051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291781#comment-17291781
]
Herve Boutemy commented on MNG-7051:
------------------------------------
thank you for the explanations: I think something should be added to
https://maven.apache.org/ref/current/maven-embedder/
bq. If I understand correctly, those changes make MNG-7052 superfluous, is that
correct?
there were good ideas of validation improvements during the different
discussions and reviews:
- for profile id: don't access comma or space
- for coordinate id: don't accept dot as first character
in the description, MNG-7052 was too vague IMHO, then perhaps this one should
be dropped, but other good up-for-grabs issues could be created for good ideas
MNG-7107 is really needed quite fast because current profile id validation is
really too strict, breaks too many builds like "jdk9+" profile id: but we have
time to work on good additional ideas
> Optionally skip non-existing profiles
> -------------------------------------
>
> Key: MNG-7051
> URL: https://issues.apache.org/jira/browse/MNG-7051
> Project: Maven
> Issue Type: Sub-task
> Components: Profiles
> Reporter: Maarten Mulders
> Assignee: Martin Kanters
> Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> For Maven 4, the behaviour of the {{-P}} command line option will change:
> * {{-P apache-release}} will activate the *apache-release* profile. If such
> a profile cannot be found, the build will break.
> * {{-P ?apache-release}} will activate the *apache-release* profile. If such
> a profile cannot be found, the build will continue but log a warning.
> {color:#ff0000}
> Note that this breaks the current behaviour of Maven 3 in two ways:
> {color}
> # {{-P apache-release}} will currently log a warning and not break the build.
> That behaviour can be restored by adding the {{?}}.
> # A profile that has an identifier that not valid (i.e., contains anything
> else than {{a}} - {{z}}, {{A}} to {{Z}}, {{0}} - {{9}}, {{-}}, {{_}} or
> {{.}}) will break the build.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
