aalmiray commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-827953865
Alright. If I understood correctly, removing the `@Parameter` annotation is the compromise that will let this PR be merged. However, what we accomplish with that is: - making it harder for not Maven savvy developers to "break" a build by "inadvertently" (by ignorance) or "incorrectly" (by mistake) if they happen to set a property exposed by the plugin (`shade.skip` in this case). In this regard the compromise would suffice. - making it harder for Maven savvy people to accomplish the original use case, as now they have to explicitly add a configuration block with a property of their choosing (such as `shade.skip`, `my.shade.skip`, `why.is.this.not.the.default.shade.skip`, etc), that is, if they want to switch between shade and none-shade with a command property or a pom property. This implies adding a configuration block. As the original use case states that's exactly the thing I'd like to avoid, as the shade plugin is defined by a parent POM outside of my control. If I have to redefine the plugin section to add one additional explicit property I might as well redefine everything and put it in a profile or whatever. Thus removing the parameter helps newbies but irks experts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
