aalmiray commented on pull request #90: URL: https://github.com/apache/maven-shade-plugin/pull/90#issuecomment-828211073
> > removing the @parameter annotation is the compromise that will let this PR be merged. > > Just the property value (you can keep it to get it configurable in the pom and have a properly documented default. OK > > Thus removing the parameter helps newbies but irks experts. > > As explained before it is not really true. Alright, I wouldn't call myself a Maven expert but I'm definitely not a newbie anymore. Still this irks me, so ... > What about not adding a skip parameter but a skipClassified parameter which can have a property (hopefully you find a shorter name ;))? Issue is only about the default artifact, not all other executions. > Would it make everyone happy? I'm afraid I do not understand what's being proposed here. The fact that shade replaces the original artifact _by_default_ is the root of the problem. IMHO that's the wrong thing to do however I'm aware that the current behavior has been like this for, well, since forever, and changing it would be more catastrophic than adding a skip field with a default property name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
