[
https://issues.apache.org/jira/browse/MNG-7170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361593#comment-17361593
]
Robert Scholte commented on MNG-7170:
-------------------------------------
I wanted to investigate if this field method is still required. While rewriting
the DefaultModelBuilder I was able to remove several pieces of code that were
using this code.
To me it still looks a bit weird: this is the only field that cannot be read
from the pom, but is set after post-processing.
The model itself shouldn't need this information. The Reader of the Model
already says {{read ModelSource X}} so it knows the location.
It is good to know there's a case we can use to validate this.
> Allow to associate pomFile/${basedir} with
> DefaultProjectBuilder.build(ModelSource, ...)
> ----------------------------------------------------------------------------------------
>
> Key: MNG-7170
> URL: https://issues.apache.org/jira/browse/MNG-7170
> Project: Maven
> Issue Type: Improvement
> Components: core
> Affects Versions: 3.8.1
> Reporter: Mickael Istria
> Priority: Major
>
> In LemMinX-Maven Language Server for pom.xml files, we're building models
> from "working copy" (unsaved) pom files. We do so by invoking
> {code}DefaultProjectBuilder.build( ModelSource modelSource,
> ProjectBuildingRequest request ){code}
> One pitfall is that this cascades to pomFile being null for the Model, and as
> a result {code}${basedir}{code} is not resolved.
> One could expect that the {code}ModelSource2.getLocationURI(){code} could be
> used to derive the pomFile when possible. LemMinX-Maven happens to properly
> set this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
