[ 
https://issues.apache.org/jira/browse/MNG-7170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17361669#comment-17361669
 ] 

Mickael Istria commented on MNG-7170:
-------------------------------------

> The model itself shouldn't need this information. The Reader of the Model 
> already says {{read ModelSource X}} so it knows the location.

I agree it would be best. A setter here is probably the cause why the getter 
returns null in some cases: the issue with getters is that it's never clear 
who's supposed to call them.

So do I understand it right that there will be no Maven 3.8.2? When is Maven 
4.0 expected to be released?

> Allow to associate pomFile/${basedir} with 
> DefaultProjectBuilder.build(ModelSource, ...)
> ----------------------------------------------------------------------------------------
>
>                 Key: MNG-7170
>                 URL: https://issues.apache.org/jira/browse/MNG-7170
>             Project: Maven
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 3.8.1
>            Reporter: Mickael Istria
>            Priority: Major
>
> In LemMinX-Maven Language Server for pom.xml files, we're building models 
> from "working copy" (unsaved) pom files. We do so by invoking
> {code}DefaultProjectBuilder.build( ModelSource modelSource, 
> ProjectBuildingRequest request ){code}
> One pitfall is that this cascades to pomFile being null for the Model, and as 
> a result {code}${basedir}{code} is not resolved.
> One could expect that the {code}ModelSource2.getLocationURI(){code} could be 
> used to derive the pomFile when possible. LemMinX-Maven happens to properly 
> set this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to