kriegaex commented on pull request #104:
URL:
https://github.com/apache/maven-shade-plugin/pull/104#issuecomment-883939661
I experimentally cherry-picked the commit from #108 into this PR (not pushed
yet) and added directory scanning. The scan is called and seems to do the right
thing, but the current Maven module in which Shade is executed is not included
when populating `MinijarFilter.removable`. That means,
* minimisation does not work in this case, i.e. all classes, no matter if
service provider stuff or not, are kept, the own module is never minimised,
* a directory scanning implementation is useless.
So before adding such an implementation to Shade, we need to discuss the
bigger issue of whether we want minimisation to encompass the own module,
because this would be a breaking change. Only then would it make any sense to
add directory scanning to the minimisation filter, because otherwise it simply
would have no effect. If we answer that question with "yes", we can decide if
self-minimisation (I just invented the term) should be done
* mandatorily,
* optionally, defaulting to no (opt-in) for backward compatibility or
* optionally, defaulting to yes (opt-out) for people who do not like the
new default.
WDYT, @rmannibucau? @rfscholte, you implemented the service filtering part
of minification. Your opinion would also be valuable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
